Add decorator places providers that select or transform places returned from inner providers#7
Draft
Add decorator places providers that select or transform places returned from inner providers#7
Conversation
Collaborator
VikiPeeva
commented
Oct 28, 2025
VikiPeeva
commented
- Added multiple decorator providers as static methods in PlacesProvider
- The current problem is that the providers sometimes need to be called in a specific order, and this is not something that is restricted by the current implementation
- Before the pull request is closed, PlaceChooser, PlaceChooserBuilder, and PlaceChooserDecorator should be made obsolete
…turned from the previous provider
alkuzman
reviewed
Oct 28, 2025
|
|
||
| static PlacesProvider onlyForActivities(PlacesProvider baseProvider, Set<String> activities) { | ||
| return () -> baseProvider.provide().stream() | ||
| .map(new IncludedActivitiesPlaceTransformer(activities)) |
Collaborator
There was a problem hiding this comment.
Does this filter out transitions from places that are not in the list?
|
|
||
| static PlacesProvider noEmptyIOPlaces(PlacesProvider baseProvider) { | ||
| return () -> baseProvider.provide().stream() | ||
| .filter(new NonSelfLoopPlacePredicate()) |
Collaborator
There was a problem hiding this comment.
This seems to be the wrong predicate.
|
|
||
| static PlacesProvider onlyOccurringInProximity(PlacesProvider baseProvider, int proximity, XLog log) { | ||
| return () -> baseProvider.provide().stream() | ||
| .map(new PassageUsagePlaceTransformer(LogUtils.getFollowRelations(log, proximity))) |
Collaborator
There was a problem hiding this comment.
Don't understand this. Maybe it would be nice if you document what these decorators actually are supposed to do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.