Fix banner build#2983
Merged
ArthurSens merged 1 commit intomainfrom May 6, 2026
Merged
Conversation
Signed-off-by: Arthur Silva Sens <arthursens2005@gmail.com>
Contributor
|
I have not had to deal with server vs client components in Mantine, but according to their docs, all components are already client components. Actually turns out that sometimes |
Member
Author
|
Ah gotcha, so the only fix here is that we're adding |
Contributor
|
I'm not sure @ArthurSens. Javascript has a lot of "magic" that I find hard to reason about. In this case, it's what decides if a component is a client component or a server component. I think these changes are probably fine. |
Member
Author
|
Thank you for the help @sysadmind ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #2978
The logs made me think that the problem was while rendering old release pages from the Prometheus repository, but after further investigation, the problem was indeed on the banner!
The banner was already broken before the changes in #2978, but the change to the active date finally caused the build to render it, whereas it had not been rendered before.
I'm definitely not a front-end developer, so I rely a lot on LLM tools to make the fixes here. Please let me know if you have better ways to fix this!
Logs for the build failure on main can be seen here: https://app.netlify.com/projects/prometheus-docs/deploys/69fb29ec6ee9e60008fe05f2
Root cause analysis from the LLM: