WebGL: Apply per‑vertex stroke color to POINTS #8380
Merged
+41
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yugalkaushik <yugalkaushik14@gmail.com>
perminder-17
approved these changes
Jan 4, 2026
Collaborator
perminder-17
left a comment
perminder-17
left a comment
There was a problem hiding this comment.
Looks good to me! Are you also intereseted in working on dev-2.0 branch as well? Since I see the same bug on 2.x versions as well?
@davepagurek do you have any suggestions to this PR?
Contributor
Author
Hi, Yes I can work on that issue if this approach is good. |
Contributor
|
I think this works! As mentioned in #7839, a possible approach for this is to deprecate the point shader and have it go through the stroke system instead, and that's what is happening in the 2.x branch now, so we should have per-point colors in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7839
Before
beginShape(POINTS) ignored per‑vertex stroke() changes because the point shader used a uniform uMaterialColor only; lines/triangles already passed aVertexColor and interpolated as expected. This made POINTS single‑color even when stroke() was set per vertex.
After
POINTS now honor per‑vertex stroke colors by passing aVertexColor to the point shader and binding it from vertexStrokeColors. Single point() continues to use the uniform stroke color.
Behavior
beginShape(POINTS) now renders each vertex with its own stroke() color.
point() (standalone) continues to use the uniform stroke() color.
LINES/TRIANGLES behavior unchanged.