Apply review feedback: rename confirmButtonRef and add Storybook args support #7522
+6
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses review feedback from PR #7510 to improve the
SettingMaxHeightstory implementation for better clarity and e2e/VRT test compatibility.Changelog
Changed
confirmButtonReftocloseButtonRefinSettingMaxHeightstory to accurately reflect the element it referencesSettingMaxHeightstory to accept StorybookArgsparameter, enabling e2e/VRT tests to control overlay state viaargs: {open: true}isOpen || opento support both internal state and Storybook argsuseFocusTrapdisabled condition to!isOpen && !opento match render logicRollout strategy
Testing & Reviewing
Story now follows the same pattern as
DialogOverlayandDropdownOverlayfor args handling. Verify the story renders correctly in Storybook withargs: {open: true}.Merge checklist
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.