Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Feb 10, 2026

Addresses technical debt from PR #7510 review comments: corrects focus management, CSS positioning, and mobile Safari viewport calculations.

Changelog

Changed

  • Overlay.module.css and ActionMenu.module.css: Replace 100vh with 100dvh in max-height calculations to prevent clipping behind mobile browser chrome
  • Overlay.features.stories.tsx: Attach confirmButtonRef to close button for proper initial focus behavior
  • Overlay.features.stories.module.css: Add position: relative to .ScrollableContent to establish containing block for absolutely positioned close button

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Storybook "SettingMaxHeight" example validates focus trap and scrollable content behavior. Mobile Safari testing confirms overlays no longer clip behind browser UI.

Merge checklist


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2026

⚠️ No Changeset found

Latest commit: 1ae6d5b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

…e 100dvh

Co-authored-by: francinelucca <40550942+francinelucca@users.noreply.github.com>
Copilot AI changed the title [WIP] Chore ensure max-height does not surpass viewport height in Overlay, ActionMenu Apply review feedback: fix initialFocusRef, positioning, and mobile viewport handling Feb 10, 2026
Copilot AI requested a review from francinelucca February 10, 2026 03:51
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github-ui depends on. If you are GitHub staff, test these changes with github/github-ui using the integration workflow. Or, apply the integration-tests: skipped manually label to skip these checks.

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Feb 10, 2026
@francinelucca francinelucca added the skip changeset This change does not need a changelog label Feb 10, 2026
@francinelucca francinelucca marked this pull request as ready for review February 10, 2026 03:53
@francinelucca francinelucca requested a review from a team as a code owner February 10, 2026 03:53
@francinelucca francinelucca merged commit 42f47e8 into chore/fix-max-height-attributes Feb 10, 2026
51 of 52 checks passed
@francinelucca francinelucca deleted the copilot/sub-pr-7510 branch February 10, 2026 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants