Apply review feedback: fix initialFocusRef, positioning, and mobile viewport handling #7519
+12
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses technical debt from PR #7510 review comments: corrects focus management, CSS positioning, and mobile Safari viewport calculations.
Changelog
Changed
Overlay.module.cssandActionMenu.module.css: Replace100vhwith100dvhin max-height calculations to prevent clipping behind mobile browser chromeOverlay.features.stories.tsx: AttachconfirmButtonRefto close button for proper initial focus behaviorOverlay.features.stories.module.css: Addposition: relativeto.ScrollableContentto establish containing block for absolutely positioned close buttonRollout strategy
Testing & Reviewing
Storybook "SettingMaxHeight" example validates focus trap and scrollable content behavior. Mobile Safari testing confirms overlays no longer clip behind browser UI.
Merge checklist
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.