Conversation
…e for packages in old Poseidon versions
…o added row-wise consistency checks accordingly
…lumns when writing .janno files
.janno column sorting with special treatment of `_Note` columns
implemented new ByteString for PoseidonID and GroupNames, with character warning
Poseidon version cli for validate and jannocoalesce
Changes to .janno and .ssf columns for Poseidon v3.0.0
…ecause the newer Lamnidis package got retired
|
Thanks for starting this big integration! I think we could go to v2.0.0.0 when this is merged. |
|
OK amazingly this is finished with relatively minimal further changes needed. I suggest we keep this in draft stage until #351 is merged in. But one thing that we still need to do here is to adapt the github workflow for the release compilation. I took a brief look, and it seems more than a simple addition here or there, because now we need multiple executables to be built and added to a release. If you have capacity, @nevrome, please have a look. Otherwise I would try to adapt this with help of Chat-AI. Thanks. |
|
OK - great! It doesn't compile yet due to some syntax error, but we can look into this when we want to merge (after #351). For the moment thank you for preparing all of this! Must have been a good deal of work 🙏 |
|
Really? Hmm, it compiled for me, I even tried |
|
So, running |
|
Ah wait... tests fail, and also stylish-haskell... I think I haven't tested the tests. Sorry for that. On it. |
|
All fixed. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #369 +/- ##
==========================================
- Coverage 56.98% 51.71% -5.28%
==========================================
Files 33 36 +3
Lines 5052 5857 +805
Branches 549 642 +93
==========================================
+ Hits 2879 3029 +150
- Misses 1624 2186 +562
- Partials 549 642 +93 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Draft Pull Request to add Xerxes codebase. Work in progress. To be merged into master after #351 has been fully merged.