Fix Eigen iterative solver lifetime problem#91
Merged
iiiian merged 1 commit intopolyfem:mainfrom Mar 12, 2026
Merged
Conversation
teseoch
approved these changes
Feb 18, 2026
3e27910 to
662cacf
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
=======================================
Coverage 81.66% 81.67%
=======================================
Files 49 49
Lines 2024 2025 +1
Branches 269 269
=======================================
+ Hits 1653 1654 +1
Misses 371 371
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Eigen iterative solver stores a reference to input matrix A and expect it to remain valid.
See https://libeigen.gitlab.io/eigen/docs-nightly/classEigen_1_1IterativeSolverBase.html#a3b0d9691964793bd55937666426fefbf.
Currently we do not make a copy and this results in segmentation fault when A is destroyed before the
compute()call. This PR fix this by manually copying A.An alternative solution is to have a API with clear lifetime expectancy.
Changes
factorize().const StiffnessMatrix &Abut some methods in Eigen solver useconst StiffnessMatrix &Kinstead. I change the parameter name toAfor consistency.