coll: update the json selection of MPIR_Bcast_intra_scatter_ring_allgather#7332
Draft
hzhou wants to merge 2 commits intopmodels:mainfrom
Draft
coll: update the json selection of MPIR_Bcast_intra_scatter_ring_allgather#7332hzhou wants to merge 2 commits intopmodels:mainfrom
hzhou wants to merge 2 commits intopmodels:mainfrom
Conversation
For some algorithm, e.g. MPIR_Bcast_intra_scatter_ring_allgather, what matters is not message size, but message size per process, since that determines whether each round is bandwidth-bound.
The MPIR_Bcast_intra_scatter_ring_allgather won't perform if the per_proc_msg_size (chunk size) is too small, which accumulates latency in each round.
Contributor
|
Did you do a performance test with this, or are these changes just based on the conversation earlier this week? Its on my TODOs to do some performance runs on Aurora, so I can try testing this too |
Contributor
Author
Thanks for volunteering! :) The patch is to address the obvious issue so it don't perform outrageously bad. Yes, we should use tests to finetune the threshold. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The MPIR_Bcast_intra_scatter_ring_allgather won't perform if the
per_proc_msg_size (chunk size) is too small, which accumulates latency
in each round.
Fixes #7330
[skip warnings]
Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.