Merged
Conversation
Collaborator
Member
|
Maybe we have to get rid of this validation as well. |
Member
Author
Thanks for comment, addressed by 8d061cc |
Collaborator
|
The following files are not gofmt-ed. By commenting pkg/model/common.pb.go--- pkg/model/common.pb.go.orig
+++ pkg/model/common.pb.go
@@ -21,11 +21,12 @@
package model
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
- reflect "reflect"
- sync "sync"
)
const (
|
Collaborator
Member
|
Nice catch! |
Collaborator
Member
|
/changelog |
Collaborator
|
@knanao: Changelog has been generated in response to this comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Make the Terraform module version field optional
Which issue(s) this PR fixes:
Fixes #3531
Does this PR introduce a user-facing change?: