Add contextWindow to ClaudeModelOptionsPatch#1536
Open
Alexx999 wants to merge 1 commit intopingdotgg:mainfrom
Open
Add contextWindow to ClaudeModelOptionsPatch#1536Alexx999 wants to merge 1 commit intopingdotgg:mainfrom
Alexx999 wants to merge 1 commit intopingdotgg:mainfrom
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Added contextWindow to ClaudeModelOptionsPatch
Why
The option to select Context Window is visible, but broken (selecting anything but default flickers and reverts back)
Checklist
Note
Low Risk
Low risk schema-only change that expands the server settings patch contract for Claude model options; main risk is minor compatibility issues if consumers assume
contextWindowcannot be patched.Overview
Updates the server settings patch schema so
textGenerationModelSelection.optionsfor theclaudeAgentprovider can include an optionalcontextWindowfield (viaClaudeModelOptionsPatch). This unblocks persisting context window selection through patch updates instead of being dropped during validation/decoding.Written by Cursor Bugbot for commit f4e3423. This will update automatically on new commits. Configure here.
Note
Add
contextWindowfield toClaudeModelOptionsPatchschemaAdds an optional
contextWindowproperty to theClaudeModelOptionsPatchstruct in settings.ts, reusing the field definition fromClaudeModelOptions.Macroscope summarized f4e3423.