tests: rebalance heavy integration test groups#4256
tests: rebalance heavy integration test groups#4256tenfyzhong wants to merge 1 commit intopingcap:masterfrom
Conversation
Move several cases from G05 to G01/G02 in heavy integration tests to avoid a single-group bottleneck.\n\nRef pingcap#4255 Signed-off-by: tenfyzhong <tenfy@tenfy.cn>
ti-chi-bot
bot
added
the
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Summary of ChangesHello @tenfyzhong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request aims to improve the efficiency of continuous integration by rebalancing heavy integration test groups. By redistributing specific long-running tests across different groups and consolidating others, the changes are designed to reduce the overall tail runtime of the CI pipeline without impacting test coverage or functionality. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
📝 WalkthroughWalkthroughThe pull request rebalances integration test groups to optimize CI runtime. G01 and G02 are expanded with additional tests, while G05 is narrowed to reduce its execution time, addressing an identified performance bottleneck. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ti-chi-bot
bot
added
the
size/XS
|
/test mysql-integration-heavy-next-gen |
|
@tenfyzhong: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test pull-cdc-mysql-integration-heavy-next-gen |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tests/integration_tests/run_heavy_it_in_ci.sh`:
- Line 37: The test-group string contains a trailing space in the token list
('ddl_for_split_tables_with_failover in_flight_syncpoint_during_scheduling ')
which can produce an empty test name when split; remove the trailing space (or
trim the variable) so the value becomes 'ddl_for_split_tables_with_failover
in_flight_syncpoint_during_scheduling' (or call a trim on the variable before
splitting) to avoid emitting an empty test token.
| 'ddl_for_split_tables_with_random_move_table syncpoint_check_ts random_drop_message' | ||
| # G02 | ||
| 'ddl_for_split_tables_with_failover' | ||
| 'ddl_for_split_tables_with_failover in_flight_syncpoint_during_scheduling ' |
There was a problem hiding this comment.
Remove trailing space to avoid an empty test token.
The trailing space in the group string can yield an empty case name depending on how run.sh splits the list; safer to trim it. Line 37.
🧹 Proposed fix
-'ddl_for_split_tables_with_failover in_flight_syncpoint_during_scheduling '
+'ddl_for_split_tables_with_failover in_flight_syncpoint_during_scheduling'📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| 'ddl_for_split_tables_with_failover in_flight_syncpoint_during_scheduling ' | |
| 'ddl_for_split_tables_with_failover in_flight_syncpoint_during_scheduling' |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@tests/integration_tests/run_heavy_it_in_ci.sh` at line 37, The test-group
string contains a trailing space in the token list
('ddl_for_split_tables_with_failover in_flight_syncpoint_during_scheduling ')
which can produce an empty test name when split; remove the trailing space (or
trim the variable) so the value becomes 'ddl_for_split_tables_with_failover
in_flight_syncpoint_during_scheduling' (or call a trim on the variable before
splitting) to avoid emitting an empty test token.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request rebalances heavy integration test groups to improve CI pipeline performance by reducing tail runtime. The changes are logical and align with the stated goal. I've found a minor formatting issue with a trailing whitespace that should be addressed.
| 'ddl_for_split_tables_with_random_move_table syncpoint_check_ts random_drop_message' | ||
| # G02 | ||
| 'ddl_for_split_tables_with_failover' | ||
| 'ddl_for_split_tables_with_failover in_flight_syncpoint_during_scheduling ' |
There was a problem hiding this comment.
There is a trailing whitespace at the end of this line. While it might not cause issues with the current script logic, it's best to remove it for code cleanliness and to prevent potential parsing problems in the future.
| 'ddl_for_split_tables_with_failover in_flight_syncpoint_during_scheduling ' | |
| 'ddl_for_split_tables_with_failover in_flight_syncpoint_during_scheduling' |
|
/test pull-cdc-mysql-integration-heavy-next-gen |
1 participant
What problem does this PR solve?
Issue Number: close #4255
What is changed and how it works?
tests/integration_tests/run_heavy_it_in_ci.sh.syncpoint_check_tsandrandom_drop_messagefrom G05 to G01.in_flight_syncpoint_during_schedulingfrom G05 to G02.ddl_for_split_tables_with_merge_and_split syncpointto reduce tail runtime.Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No.
Do you need to update user documentation, design documentation or monitoring documentation?
No.
Release note
Summary by CodeRabbit