Narrow array dim fetch types after isset+type guard in BooleanAnd falsey context#5686
Open
phpstan-bot wants to merge 1 commit into
Open
Narrow array dim fetch types after isset+type guard in BooleanAnd falsey context#5686phpstan-bot wants to merge 1 commit into
phpstan-bot wants to merge 1 commit into
Conversation
…sey context
After `if (isset($array['key']) && !is_string($array['key'])) { throw; }`,
PHPStan now correctly narrows `$array['key'] ?? ''` to `string` instead of
`mixed|string`. The fix creates ConditionalExpressionHolders in the BooleanAnd
falsey handler that fire when the isset condition is later confirmed (e.g.,
during coalesce evaluation).
Closes phpstan/phpstan#6202
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if (isset($array['key']) && !is_string($array['key'])) { throw; }, PHPStan now correctly narrows$array['key'] ?? ''tostringinstead ofmixed|stringprocessBooleanTruthyConditionalTypesmethod to TypeSpecifier that creates ConditionalExpressionHolders when the falsey BooleanAnd handler encounters an empty left-side (like isset on a general array dim fetch)filterByTruthyValue(isset(...))is later confirmed during coalesce evaluation, applying the type narrowing from the right side of the original&&conditionTest plan
tests/PHPStan/Analyser/nsrt/bug-6202.phpcovering:isset + !is_stringguard with??coalesceis_int,is_array,is_boolinstanceofcheck!isset || !is_stringor-pattern (already worked)make testspasses (12078 tests, 79704 assertions)make phpstanpasses (no errors)make cs-fixpassesCloses phpstan/phpstan#6202