Invalidate property types after dynamic method calls

[phpstan-bot]

Summary

Fixes phpstan/phpstan#3831

[VincentLanglet]

Lot of these changes are wrong.

The issue is with the snippet

class Template {
	
	public $footer = [];

	public function render() : string {
		$content = '';
		$this->footer = [];
		
		// START TEMPLATE COMPILER
		$this->{'compileSection'}(); // dynamic code
		// END TEMPLATE COMPILER
		
		if (count($this->footer) > 0) {
			$content = str_replace('some', 'thing', $content);
		}
		return $content;
	}

	private function compileSection(): void {
		$this->footer[] = 'section-name';
	}
	
}

$this->compileSection() invalidate correctly but
$this->{'compileSection'} or $this->{$someThing}() does not invalidate

[phpstan-bot]

Looking at bug-5501 and bug-6473, the test expectation changes in the original PR are correct. In bug-5501, $this->prop2 = 5 is assigned, then $this->isBroken() is called (which returns bool, so hasSideEffects()->maybe()), and the new behavior correctly widens 5 to int. Similarly in bug-6473, $p->visited = true followed by $p->getNeighbours() (returns Point[], hasSideEffects()->maybe()) correctly widens true to bool.

The reviewer's feedback was specifically about the dynamic method call gap. The fix I made addresses that by adding full invalidation for unknown/dynamic method calls in the else branch. This is actually more aggressive than the maybe() branch (which only invalidates constant scalar property types) — for unknown methods we do full invalidation since we can't know anything about the method's behavior.

The changes are committed and pushed. Here's a summary:

Fix: Added invalidateExpression call in MethodCallHandler.php for the case when $methodReflection is null (dynamic method calls like $this->{'compileSection'}() or $this->{$variable}()). Since the method can't be resolved, we treat it as having certain side effects and fully invalidate the callee expression — matching the behavior for known methods with hasSideEffects()->yes().

Tests: Added test cases for both the NSRT test (bug-3831.php) and the Comparison rule test (data/bug-3831.php) covering the reviewer's exact example with $this->{'compileSection'}() and $this->{$method}().

Verification: All 12077 tests pass, make phpstan reports 0 errors, make cs-fix has no violations.

[VincentLanglet]

Revert the first commit and only keep the second one, about invalidating after dynamic call

[phpstan-bot]

Done. I reverted the first commit (constant scalar property invalidation after maybe-impure calls) and kept only the dynamic method call invalidation fix. The branch now has a single clean commit that:

1. Adds invalidateExpression in the else branch of MethodCallHandler.php for when $methodReflection is null (dynamic calls like $this->{'method'}() or $this->{$var}())
2. Includes test coverage for the dynamic call case only — no changes to bug-5501, bug-6473, impure-method, bug-12393 test expectations
3. All 12076 tests pass, make phpstan reports 0 errors, no CS violations

[VincentLanglet]

load nsrt file in the RuleTest to avoid duplicates fixtures files

[phpstan-bot]

Done. I merged the rule test fixture into the existing NSRT file (adding the Template and TemplateDynamicVar classes with the count() > 0 comparisons), pointed the rule test to __DIR__ . '/../../Analyser/nsrt/bug-3831.php', and deleted the duplicate tests/PHPStan/Rules/Comparison/data/bug-3831.php. All tests pass and make phpstan is clean.