Skip to content

Do not report undefined property in isset/empty/?? for types without class names #5673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
phpstan-bot wants to merge 1 commit into from
+70 −3
Closed

Do not report undefined property in isset/empty/?? for types without class names #5673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Rules/Properties/AccessPropertiesCheck.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,10 @@ private function processSingleProperty(Scope $scope, PropertyFetch $node, string
return [];
}

if (count($type->getObjectClassNames()) === 0) {
return [];
}

$maybePropertyReflection = $this->pickProperty($scope, $type, $name);
if ($maybePropertyReflection !== null && $maybePropertyReflection->isDummy()->no()) {
return [];
Expand Down
4 changes: 1 addition & 3 deletions tests/PHPStan/Analyser/AnalyserWithCheckDynamicPropertiesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@ class AnalyserWithCheckDynamicPropertiesTest extends PHPStanTestCase
public function testBug13529(): void
{
$errors = $this->runAnalyse(__DIR__ . '/data/bug-13529.php');
$this->assertCount(1, $errors);
$this->assertSame('Access to an undefined property object::$bar.', $errors[0]->getMessage());
$this->assertSame(8, $errors[0]->getLine());
$this->assertCount(0, $errors);
}

/**
Expand Down
9 changes: 9 additions & 0 deletions tests/PHPStan/Rules/Properties/AccessPropertiesRuleTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1272,4 +1272,13 @@ public function testBug13537(): void
$this->analyse([__DIR__ . '/data/bug-13537.php'], $errors);
}

public function testBug13539(): void
{
$this->checkThisOnly = false;
$this->checkUnionTypes = true;
$this->checkDynamicProperties = true;

$this->analyse([__DIR__ . '/data/bug-13539.php'], []);
}

}
56 changes: 56 additions & 0 deletions tests/PHPStan/Rules/Properties/data/bug-13539.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
<?php

namespace Bug13539;

function broken(string $x): void {
$tmp = json_decode($x, false);

if (!isset($tmp->foo) || !isset($tmp->bar)) {
}
}

function works(string $x): void {
$tmp = json_decode($x, false);

if (!isset($tmp->foo, $tmp->bar)) {
}
}

function works_too(string $x): void {
/** @var \stdClass $tmp */
$tmp = json_decode($x, false);

if (!isset($tmp->foo) || !isset($tmp->bar)) {
}
}

function threeProperties(string $x): void {
$tmp = json_decode($x, false);

if (!isset($tmp->foo) || !isset($tmp->bar) || !isset($tmp->baz)) {
}
}

function coalesceAfterIsset(string $x): void {
$tmp = json_decode($x, false);

if (isset($tmp->foo)) {
$bar = $tmp->bar ?? null;
}
}

function issetInAndChain(string $x): void {
$tmp = json_decode($x, false);

if (isset($tmp->foo) && isset($tmp->bar)) {
}
}

function emptyAfterIsset(string $x): void {
$tmp = json_decode($x, false);

if (isset($tmp->foo)) {
if (empty($tmp->bar)) {
}
}
}
Loading