Skip to content

538: fix phpize build tool finder api verison check test #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asgrim merged 2 commits into from
Mar 18, 2026
Merged

538: fix phpize build tool finder api verison check test #552

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06e86c8
538: set phpize explicitly on TargetPlatform to ensure it is using th…
asgrim Mar 18, 2026
bb33861
Ensure the phpApiVersion we look for is wildly different from anythin…
asgrim Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions test/unit/SelfManage/BuildTools/PhpizeBuildToolFinderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,14 @@ public function testPhpizeForDifferentPhpApiVersionIsRejected(): void
putenv('PATH=' . realpath(self::GOOD_PHPIZE_PATH));

$mockPhpBinary = $this->createMock(PhpBinaryPath::class);
$mockPhpBinary->method('phpApiVersion')->willReturn('20250925');
// This should not be any API version of a real PHP, otherwise this test might pick up a wrong phpize and false-positive :D
$mockPhpBinary->method('phpApiVersion')->willReturn('30250925');
(fn () => $this->phpBinaryPath = '/path/to/php')
->bindTo($mockPhpBinary, PhpBinaryPath::class)();

$goodPhpize = realpath(self::GOOD_PHPIZE_PATH . DIRECTORY_SEPARATOR . 'phpize');
self::assertNotFalse($goodPhpize);

self::assertFalse((new PhpizeBuildToolFinder([]))->check(new TargetPlatform(
OperatingSystem::NonWindows,
OperatingSystemFamily::Linux,
Expand All @@ -123,7 +127,7 @@ public function testPhpizeForDifferentPhpApiVersionIsRejected(): void
ThreadSafetyMode::NonThreadSafe,
1,
null,
null,
new PhpizePath($goodPhpize),
)));

putenv('PATH=' . $oldPath);
Expand Down
Loading