Skip to content

Add RUN_RESOURCE_HEAVY_TESTS env var #20935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
iluuu1994 wants to merge 1 commit into
base: PHP-8.2
Choose a base branch
from
Open

Add RUN_RESOURCE_HEAVY_TESTS env var #20935

iluuu1994 wants to merge 1 commit into from

Conversation

@iluuu1994
Copy link
Member

@iluuu1994 iluuu1994 commented Jan 14, 2026 •
edited
Loading

Disable resource-heavy tests by default (>1GB of memory usage), unless the RUN_RESOURCE_HEAVY_TESTS env variable is set.

Fixes GH-20762

8.3 adds:

  • ext/bz2/tests/gh20620.phpt
  • ext/standard/tests/strings/gh18976.phpt

Higher branches I'll have to look at still.

@iluuu1994
Add RUN_RESOURCE_HEAVY_TESTS env var
ad34884 
Disable resource-heavy tests by default (>1GB of memory usage), unless the
RUN_RESOURCE_HEAVY_TESTS env variable is set.

Fixes phpGH-20762
TimWolla
TimWolla approved these changes Jan 14, 2026
View reviewed changes
Copy link
Member

@TimWolla TimWolla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except nit.

sapi/fpm/tests/proc-idle-timeout.phpt
<?php
include "skipif.inc";
if (!getenv("FPM_RUN_RESOURCE_HEAVY_TESTS")) die("skip resource heavy test");
if (!getenv("RUN_RESOURCE_HEAVY_TESTS")) die("skip resource heavy test");
Copy link
Member

@TimWolla TimWolla Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This skip message is inconsistent (hyphen vs no hyphen), same for the other FPM test.

Please unify either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TimWolla TimWolla TimWolla approved these changes

@ndossche ndossche ndossche approved these changes

@bukka bukka Awaiting requested review from bukka bukka is a code owner

@SakiTakamachi SakiTakamachi Awaiting requested review from SakiTakamachi SakiTakamachi is a code owner

@devnexen devnexen Awaiting requested review from devnexen devnexen is a code owner

Assignees

No one assigned

Labels

Extension: gd Extension: ldap Extension: pdo_dblib Extension: pdo_sqlite Extension: soap Extension: standard Extension: tidy SAPI: fpm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@iluuu1994 @TimWolla @ndossche