Fix bug #74357: lchown fails to change ownership of symlink with ZTS #20626
+0
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
This is draft as it will need some test (root only) and it will also require verifying that that CWD_EXPAND is ok as it omits also few other things. Will also need to consider Windows here. |
bukka
force-pushed
the
fs_bug74357_zts_lchown
branch
from
45ea188 to
5484ebc
Compare
Member
Author
|
hmm I somehow accidentally pushed the fix straight to PHP-8.4. I tested it locally and the test is actually limited to root and not windows and the actual effect is visible only in ZTS so it might not show much in CI possible anyway. I also did a bit more checking and there's not much to consider on Win because lchown just does not work there so hopefully it's fine as it applies only to lchown in ZTS and that wasn't really working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is not possible to change the owner of the link file in ZTS mode because
virtual_chmodcallsvirtual_file_exwithCWD_REALPATHthat causes reading the link and updating the path. This changes it CWD_EXPAND which does not do.