Skip to content

Guided tour not coming for existing users#2892

Merged
abose merged 6 commits into
mainfrom
ai
May 12, 2026
Merged

Guided tour not coming for existing users#2892
abose merged 6 commits into
mainfrom
ai

Conversation

@abose
Copy link
Copy Markdown
Member

@abose abose commented May 11, 2026

No description provided.

abose added 2 commits May 11, 2026 22:39
Introduce a small coordinator (utils/BootGreetings) that named boot dialogs
register against. Consumers like the onboarding tour await
`allDismissed()` so they no longer race the auto-update "What's New"
dialog or the pro trial-start dialog.

- New utils/BootGreetings: registerBlocker / unblockBlocker / allDismissed.
  Misuse (missing name, duplicate name, unknown unblock) is reported via
  logger.reportError instead of throwing — boot stability matters more.
- appUpdater (Tauri + Electron): register an `updater-*` gate and unblock
  it after the existing "What's New" dialog dismisses, or immediately on
  every early-return path.
- phoenix-tour: wait on BootGreetings.allDismissed() before starting.
  Drop the pre-wait button-presence and editor-collapsed gates so the
  tour fires on every first run; report missing step anchors via
  logger.reportError rather than bailing silently.
- strings: add PROMO_PRO_WHATS_NEW_TITLE / PROMO_PRO_WHATS_NEW_MESSAGE
  used by the pro paid-user "what's new" dialog (lives in phoenix-pro).
abose added 4 commits May 11, 2026 23:12
A 5-minute ticker rolls in-progress design-mode time into a session
aggregate, and exits flush the partial stretch so nothing between the
last tick and an exit is lost. Each bucket (5/10/15/20/30/45/60 min)
is emitted at most once as Metrics.EVENT_TYPE.UI / "designTime" /
"{N}M" when the aggregate first crosses it.
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
3.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@abose abose merged commit 166c163 into main May 12, 2026
11 of 21 checks passed
@abose abose deleted the ai branch May 12, 2026 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant