Skip to content

Terminal context menu improvements #2891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abose merged 2 commits into from
May 11, 2026
+10 −8
Merged

Terminal context menu improvements #2891

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9347395
fix: terminal paste button opens another paste option from chromium
devvaannsh May 10, 2026
a664284
fix: terminal paste tests fails
devvaannsh May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/extensionsIntegrated/Terminal/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -846,10 +846,12 @@ define(function (require, exports, module) {
const active = _getActiveTerminal();
if (active && active.isAlive) {
active.focus();
navigator.clipboard.readText().then(function (text) {
Phoenix.app.clipboardReadText().then(function (text) {
if (text) {
nodeConnector.execPeer("writeTerminal", {id: active.id, data: text});
}
}).catch(function (err) {
console.error("Terminal paste failed:", err);
});
}
});
Expand Down
14 changes: 7 additions & 7 deletions test/spec/Terminal-integ-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -708,14 +708,14 @@ define(function (require, exports, module) {
await openTerminal();
await waitForShellReady();

// Mock clipboard.readText to return a known string,
// since the test iframe may not have clipboard
// permission (no window focus).
// Mock Phoenix.app.clipboardReadText to return a
// known string, since the test iframe may not have
// clipboard permission (no window focus).
const pasteText = "PASTEMARKER456";
const clipboard = testWindow.navigator.clipboard;
spyOn(clipboard, "readText").and.returnValue(
testWindow.Promise.resolve(pasteText)
);
spyOn(testWindow.Phoenix.app, "clipboardReadText")
.and.returnValue(
testWindow.Promise.resolve(pasteText)
);

// Execute the paste command
await CommandManager.execute("terminal.paste");
Expand Down
Loading