Add preserve-origin and timestamp for table repair operations. #64
+912
−138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement preserve-origin feature that maintains original replication origin node ID and LSN when repairing rows during recovery scenarios. This prevents replication conflicts when the origin node returns to the cluster.
Updated the documentation for the table-repair command to enhance clarity and structure. Improved syntax formatting and added details about options and behavior.
mason-sharp
requested changes
Jan 22, 2026
Member
mason-sharp
left a comment
mason-sharp
left a comment
There was a problem hiding this comment.
A couple of comments.
Also, please add tests.
| } | ||
|
|
||
| // Step 2: Setup xact with LSN and timestamp (BEFORE DML) | ||
| if err := task.setupReplicationOriginXact(tx, groupOriginInfo.lsn, groupOriginInfo.commitTS); err != nil { |
Member
There was a problem hiding this comment.
Is this setting the timestamp only once for the group, and not each individual row, which may have a different timestamp?
| } | ||
| } | ||
| addNullUpdate(updatesByNode, node1Name, row1, col, val2, sourceRow) | ||
| } else if val2 == nil && val1 != nil { |
Member
There was a problem hiding this comment.
What happens when each row has NULL on different columns? Do they each end up updating their respective origins to each other?
If so, I am not sure what we should do (perhaps not change?).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement preserve-origin feature that maintains original replication origin node ID and timstamp when repairing rows during recovery scenarios. This prevents replication conflicts when the origin node returns to the cluster.
Test Scenario
(no
--preserve-origin)(
--preserve-origin)