Get rid of weird printf macros#619
Merged
AndersAstrand merged 2 commits intopercona:mainfrom Feb 13, 2026
Merged
Conversation
This macro was extremely weirdly named and only used in one place.
This weirdly named macro didn't add anything of value. Just use strlcpy() instead. All of these strings are regular NUL-terminated strings.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #619 +/- ##
==========================================
+ Coverage 85.33% 85.44% +0.11%
==========================================
Files 3 3
Lines 1343 1340 -3
Branches 216 217 +1
==========================================
- Hits 1146 1145 -1
+ Misses 93 92 -1
+ Partials 104 103 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jeltz
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These macros were just weird and pointless. All of these strings are regular NUL-terminated strings so there is no need for the strange memcpy() done here.