feat(CalendarMonth): add select appendTo passthrough#12391
Merged
thatblindgeye merged 3 commits intopatternfly:mainfrom May 7, 2026
Merged
feat(CalendarMonth): add select appendTo passthrough#12391thatblindgeye merged 3 commits intopatternfly:mainfrom
thatblindgeye merged 3 commits intopatternfly:mainfrom
Conversation
WalkthroughAdds an optional ChangesCalendarMonth Component
Sequence Diagram(s)sequenceDiagram
participant CalendarMonth
participant Select
participant DOM
CalendarMonth->>Select: provide popperProps.appendTo = monthAppendTo
Select->>DOM: append popper menu to monthAppendTo container
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
|
Preview: https://pf-react-pr-12391.surge.sh A11y report: https://pf-react-pr-12391-a11y.surge.sh |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/react-core/src/components/CalendarMonth/CalendarMonth.tsx`:
- Around line 84-85: The prop type for monthSelectProps is too strict (it uses
SelectProps which requires toggle); change the declaration of monthSelectProps
to use Partial<SelectProps> so callers can pass only subsets like popperProps.
Update the type on the CalendarMonth component/interface (the monthSelectProps
property) and adjust any usage sites that assume required fields (e.g., avoid
directly calling monthSelectProps.toggle without existence checks) to handle
possibly-undefined members after making it Partial.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a5e62b52-f57d-4114-8cf4-5182be9d70f3
📒 Files selected for processing (1)
packages/react-core/src/components/CalendarMonth/CalendarMonth.tsx
Comment on lines
+84
to
+85
| /** Additional props passed to the month select component. */ | ||
| monthSelectProps?: SelectProps; |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Verify SelectProps requires toggle
rg -n --type=ts 'export interface SelectProps|toggle:\s*SelectToggleProps' packages/react-core/src/components/Select/Select.tsx
# Verify CalendarMonth typing for monthSelectProps
rg -n --type=ts 'monthSelectProps\?:\s*SelectProps|monthSelectProps\?:\s*Partial<SelectProps>' packages/react-core/src/components/CalendarMonth/CalendarMonth.tsxRepository: patternfly/patternfly-react
Length of output: 260
monthSelectProps requires the full SelectProps interface, blocking partial passthrough use-cases
Line 85 types monthSelectProps as SelectProps, which has a required toggle property. This prevents callers from passing only specific options like popperProps, making the API ergonomically awkward for typical passthrough scenarios.
Change to Partial<SelectProps> to allow flexible prop passthrough:
Suggested fix
- monthSelectProps?: SelectProps;
+ monthSelectProps?: Partial<SelectProps>;📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| /** Additional props passed to the month select component. */ | |
| monthSelectProps?: SelectProps; | |
| /** Additional props passed to the month select component. */ | |
| monthSelectProps?: Partial<SelectProps>; |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@packages/react-core/src/components/CalendarMonth/CalendarMonth.tsx` around
lines 84 - 85, The prop type for monthSelectProps is too strict (it uses
SelectProps which requires toggle); change the declaration of monthSelectProps
to use Partial<SelectProps> so callers can pass only subsets like popperProps.
Update the type on the CalendarMonth component/interface (the monthSelectProps
property) and adjust any usage sites that assume required fields (e.g., avoid
directly calling monthSelectProps.toggle without existence checks) to handle
possibly-undefined members after making it Partial.
kmcfaul
force-pushed
the
calendarmonth-props
branch
from
2caf68f to
9e3578f
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/react-core/src/components/CalendarMonth/CalendarMonth.tsx`:
- Around line 84-89: The JSDoc examples incorrectly use menuAppendTo instead of
the actual prop monthAppendTo; update the doc block for the CalendarMonth
component (the JSDoc above the monthAppendTo prop) to use monthAppendTo in all
example lines (e.g. monthAppendTo={() => document.body} and
monthAppendTo={document.getElementById('target')}) so the examples match the
public API and avoid misleading consumers.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: eab2bad0-c8d7-4aad-897d-b02405b0716a
📒 Files selected for processing (1)
packages/react-core/src/components/CalendarMonth/CalendarMonth.tsx
thatblindgeye
approved these changes
May 7, 2026
wise-king-sullyman
approved these changes
May 7, 2026
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/react-core/src/components/CalendarMonth/CalendarMonth.tsx`:
- Around line 84-90: Add a new prop monthSelectProps to the CalendarProps
interface and use it in CalendarMonth to pass-through and allow overriding all
Select and popperProps options instead of only mapping monthAppendTo to
popperProps.appendTo; specifically, update the CalendarMonth component so it
merges monthSelectProps into the Select invocation (preserving existing
controlled props) and merges popperProps such that monthSelectProps.popperProps
takes precedence, falling back to monthAppendTo when no appendTo is provided,
and ensure other popperProps (placement, strategy, etc.) are forwarded
unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 31a24d0a-f28a-4529-bcf4-56399d4ecc01
📒 Files selected for processing (1)
packages/react-core/src/components/CalendarMonth/CalendarMonth.tsx
kmcfaul
changed the title
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What: Closes #12414
Allows a user to override the select
appendToif their user case requires a different configuration.Summary by CodeRabbit