Conversation
23c36d4 to
3f9f4a6
Compare
sandreae
reviewed
Jan 19, 2026
dad8f49 to
1114f61
Compare
jsparber
commented
Jan 20, 2026
adzialocha
reviewed
Jan 27, 2026
Collaborator
|
Here's an issue @sandreae and I found while testing this together:
Any ideas, @jsparber ? |
Collaborator
Author
Could make sense even though it might make entering a document slower. Anyhow, this doesn't seam relevant here. |
Member
I could reproduce the issue in a test in Edit: Yes, can confirm. I'm creating an issue here p2panda/p2panda#967 |
3d55e6e to
dba1061
Compare
3f1b3a9 to
c827460
Compare
Collaborator
Author
|
Blocked on the p2panda release, but ready from my side. |
This allows to report network errors on the set_connection_mode(), but creating a node will always succeed.
c827460 to
0c3e06b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.