-
Notifications
You must be signed in to change notification settings - Fork 66
Pull in latest networking dependencies #9752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is likely going to fail until we have CI images on the Buildomat hosts with recent-enough OPTE bits, version 0.39.455. That is in the works per Señor Clulow here |
79979b1 to
9b6b8c6
Compare
|
There is a large number of failing tests, mostly timeouts in the multicast stuff. I haven't root-caused that yet, but the actual Helios deploy job that uses the new image with OPTE 0.39 did in fact work. |
|
Ok, this overlaps with #9746. Also, all the multicast tests are failing because we're running against a version of Dendrite that doesn't have those endpoints implemented. As as side note, we can see that the logs are in fact getting a bunch of fatal errors, e.g., from here: That's because we're catching absolutely any error in talking to DPD and assuming it'll resolve: omicron/nexus/tests/integration_tests/multicast/mod.rs Lines 439 to 445 in 5472a8a
This one definitely will never resolve. We should probably check the status code there and be more selective. There's really only a few errors that are retryable, 503s for example, and so most should cause us to bail here. |
#9746 is now integrated. It puts the multicast tests behind a feature flag, so you shouldn't hit those anymore. |
c797f51 to
66c9cf8
Compare
|
Hit the clippy lint Nils fixed in #9763, will rebase on that. |
This updates maghemite, dendrite, and OPTE for the run-up to the IPv6 integration and attached subnet work. It does not actually use any new functionality, but makes a few small API changes required for the OPTE update.
66c9cf8 to
76eec9d
Compare
| .iter() | ||
| .map(|ip| { | ||
| let cidr = | ||
| Ipv4Cidr::new(ip.addr().into(), ip.width().try_into().unwrap()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a note for the review. Looks like this unwrap can only happen if oxnet returns a prefix length greater than 32 which should not be possible. But I think this is a sign the prefix length type needs to be stronger, or we use oxnet types in the OPTE interface, or both.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be very nice to commonize all these. That was the point of oxnet, but we need to make it no_std and probably do a lot more work to have it fit nicely in both places.
This updates maghemite, dendrite, and OPTE for the run-up to the IPv6 integration and attached subnet work. It does not actually use any new functionality, but makes a few small API changes required for the OPTE update.