Skip to content

Conversation

@joragua
Copy link
Collaborator

@joragua joragua commented Feb 9, 2026

Related Issues

App: #4725

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

Reports:

@joragua joragua self-assigned this Feb 9, 2026
@joragua joragua linked an issue Feb 9, 2026 that may be closed by this pull request
11 tasks
@joragua joragua force-pushed the feature/remove_a_space_member branch from 5ad44c8 to 71f5e34 Compare February 10, 2026 11:13
@joragua joragua marked this pull request as ready for review February 10, 2026 16:36
@joragua joragua requested a review from jesmrec February 10, 2026 16:36
@joragua joragua force-pushed the feature/remove_a_space_member branch from f05d479 to 5a288cf Compare February 11, 2026 09:31
@joragua joragua requested a review from jesmrec February 11, 2026 10:10
@jesmrec
Copy link
Collaborator

jesmrec commented Feb 11, 2026

moving to QA, since #4768 (comment) is out of CR scope. In case changes are required, will be handled as a QA report.

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 11, 2026

(1)

All steps to be done in the mobile app:

  1. Current user is the only manager in a space -> no trashbin ✅
  2. Add another user as a manager -> new manager has trashbin ✅ but the existing manager does not ❌
  3. Add another user as a manager -> all managers have now trashbin ✅

Xiaomi Redmi Note 13, Android 15
Galaxy Tab A8, Android 15
3d0e7993

Copy link
Collaborator

@jesmrec jesmrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR approved, QA time

@joragua joragua force-pushed the feature/remove_a_space_member branch from 3d0e799 to 6863e3f Compare February 11, 2026 12:19
@joragua
Copy link
Collaborator Author

joragua commented Feb 11, 2026

(1): This bug is reproducible after applying the commit that comes from this comment on the CR: #4768 (comment)

I've checked it, and the best solution here is to revert all the changes and removed that commit. It's more efficient to use SpaceMembersDiffUtil instead of mixing both methods (avoiding notifyItemRangeChanged()). Using the notify method also causes all animations to be lost, which feels so strange for the UX...

I've removed the commit and it should be fixed now 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Remove a space member

4 participants