Explicitly define class properties

[benschoch]

Summary

• Explicitly define class properties to get rid of deprecation warnings

Issues

• Fixes Deprecated: Creation of dynamic property Optimizely\Utils\CustomAttributeConditionEvaluator::$logger is deprecated #283

Issues

FSSDK-10015

[mikechu-optimizely]

Hiya @benschoch,

Thanks for the collaboration and the code update. I'm running this through our Product team for managing priority.

Are you blocked by this code change?

[benschoch]

Hey, thanks for the quick answer. It isn’t blocking, no. Even though it really spams our logs currently 😉

[mikechu-optimizely]

I've created internal ticket FSSDK-10015.

Please review and sign the Contributor License Agreement from CONTRIBUTING.md.

Thanks for the collab.

[benschoch]

Please review and sign the Contributor License Agreement from CONTRIBUTING.md.

✅

[mikechu-optimizely]

Cool. Thanks. I'm holding for Product to prioritize...but honestly (and gratefully), you've done the work. It should be low-hanging completion.

[arouchdi]

Hi @mikechu-optimizely, are there any plans to release this change sometime soon? I’d greatly appreciate any information you can share.

[mikechu-optimizely]

Hi @mikechu-optimizely, are there any plans to release this change sometime soon? I’d greatly appreciate any information you can share.

Hey @arouchdi & @benschoch. I'm realizing this ticket slipped under our radar. Our engineering manager has allocated this into a future sprint and will update here. Thanks for hanging in there.

[FarhanAnjum-opti]

Hey, @benschoch. Pulled your PR into internal PR for CI run. Closing this one in exchange for #288