Conversation
|
|
asaschachar
left a comment
asaschachar
left a comment
There was a problem hiding this comment.
LGTM! I added one comment, but overall I think this looks great.
Appreciate the thoughtfulness you put into the readme to help users use the extension correctly!
|  | ||
|
|
||
| This is how the fields correspond to the Marketo code: | ||
|  |
| "edit_page_url": "https://www.atticandbutton.us/", | ||
| "form_schema": [ | ||
| { | ||
| "default_value": "https://app-123.marketo.com/js/forms2/js/forms2.min.js", |
There was a problem hiding this comment.
Does the format of this url always have the same pattern? like "https://app-.marketo.com/js/forms2/js/forms2.min.js"
Right now the extension code is kind of generically inserting a script from some location and if the user accidentally puts in the wrong URL, they could be loading the wrong or potentially even malicious script on their page.
One way around this might be to only allow users to configure the so that we always guarantee that this extension adds a script from a marketo domain. However, this assumes marketo won't change the format of their URL.
Or we could rely on users to ensure they paste in the right script here as you are doing here.
I think this is fine either way, but would appreciate your thoughts.
3 participants
This is the editor extension to add a Marketo Form to a Page in Optimizely.