Cleaned up Integration code for listVar integration#14
Open
cooperreid-optimizely wants to merge 1 commit intomasterfrom
Open
Cleaned up Integration code for listVar integration#14cooperreid-optimizely wants to merge 1 commit intomasterfrom
cooperreid-optimizely wants to merge 1 commit intomasterfrom
Conversation
Bigspencey
reviewed
Nov 8, 2017
| shouldCleanString: true | ||
| }); | ||
| var redirectInfo = window.optimizely.get('state').getRedirectInfo(); | ||
| var list = "list1"; |
Contributor
There was a problem hiding this comment.
@cooperreid-optimizely what's the rational from moving away from a hard-coded list variable key? The reason I put this in was because customers didn't want to modify the list variable used every time so the integration would genuinely be "one click". Just wanted to confirm there's a reason before I merge in.
Contributor
Author
|
Oh okay, I didn't have a great reason to make it a dropdown, so let's just stick to a hardcoded value. As long as we call that out in the docs, I think hardcoded make a lot of sense considering it will automatically included a list of all experiment decisions.
Cooper
… On Nov 7, 2017, at 8:17 PM, Spencer Smitherman ***@***.***> wrote:
@Bigspencey commented on this pull request.
In Integrations/Analytics/Adobe Analytics/List Variable Integration/integration.js:
> var redirectInfo = window.optimizely.get('state').getRedirectInfo();
-var list = "list1";
@cooperreid-optimizely what's the rational from moving away from a hard-coded list variable key? The reason I put this in was because customers didn't want to modify the list variable used every time so the integration would genuinely be "one click". Just wanted to confirm there's a reason before I merge in.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaned up the integration code to automatically account for Array and String listVars. Removed the reverse for-loop logic.