[FSSDK-12028] use save time for event expiration in event store#1109
Merged
[FSSDK-12028] use save time for event expiration in event store#1109
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the event storage mechanism to save the storedAt timestamp and ttl separately instead of a computed expiresAt timestamp. This enables dynamic event expiration based on the current store's TTL configuration rather than the TTL at the time of storage.
Key Changes:
- Changed
StoredEventtype from storingexpiresAtto storing_timeobject withstoredAtandttlfields - Updated expiration logic to calculate expiration dynamically using current store TTL
- Maintained backward compatibility by handling events without time information
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/event_processor/event_store.ts | Refactored StoredEvent type and updated set() and processStoredEvent() methods to use new time structure with dynamic TTL-based expiration |
| lib/event_processor/event_store.spec.ts | Updated test names, variable names, and assertions to validate new time-based storage structure |
Comments suppressed due to low confidence (1)
lib/event_processor/event_store.spec.ts:211
- Avoid automated semicolon insertion (93% of all statements in the enclosing function have an explicit semicolon).
}
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
junaed-optimizely
approved these changes
Nov 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Issues