[FSSDK-11981] bug bash addressed#1097
Merged
junaed-optimizely merged 6 commits intomasterfrom Oct 20, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR enhances logging for CMAB (Contextual Multi-Armed Bandit) cache operations and fixes a missing logger dependency. The changes add four new log message constants for different cache events and ensure the DefaultCmabService receives a logger instance to use these messages.
- Added four new log message constants for CMAB cache operations (ignore, reset, invalidate, and attributes mismatch)
- Injected logger dependency into
DefaultCmabServiceand added debug logging for cache operations - Optimized code by extracting
userIdto avoid repeatedgetUserId()calls
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| lib/message/log_message.ts | Added four new log message constants for CMAB cache events |
| lib/core/decision_service/cmab/cmab_service.ts | Added logger usage for cache operations and optimized userId retrieval |
| lib/client_factory.ts | Passed logger instance to DefaultCmabService constructor |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
raju-opti
requested changes
Oct 20, 2025
raju2592
suggested changes
Oct 20, 2025
raju-opti
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Logging improvements for CMAB cache operations:
IGNORE_CMAB_CACHE,RESET_CMAB_CACHE,INVALIDATE_CMAB_CACHE,CMAB_CACHE_ATTRIBUTES_MISMATCH) inlib/message/log_message.ts.Added missing logger in
DefaultCmabService.Test plan
Existing test should pass
Issues