[FSSDK-12617] Deserialize integers as longs when using Gson#624
Open
FarhanAnjum-opti wants to merge 5 commits intomasterfrom
Open
[FSSDK-12617] Deserialize integers as longs when using Gson#624FarhanAnjum-opti wants to merge 5 commits intomasterfrom
FarhanAnjum-opti wants to merge 5 commits intomasterfrom
Conversation
muzahidul-opti
requested changes
May 7, 2026
Contributor
muzahidul-opti
left a comment
There was a problem hiding this comment.
A couple of suggestions by AI
- Consider adding a test case for nested integer values in GsonConfigParserTest.testFromJson — the OptimizelyJSONWithGsonParserTest covers nested objects, but the parser-level test only covers flat values.
- Update the comment in OptimizelyJSON.getValueInternal from Integer, Double to Long, Double (or just Number) since the behavior has changed. (Not in scope of this PR, just noting.)
muzahidul-opti
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Deserialize integers as longs instead of doubles when using Gson. This allows users to use the resultant
Mapin downstream serializers (e.g. kotlinx.serialization) more easily.Changes
ToNumberPolicy.LONG_OR_DOUBLEtoGsonConfigParserso integers deserialize asLonginstead ofDoubleGsonConfigParserTestto verify integer parsing and fix assertion argument orderOptimizelyJSONWithGsonParserTestto reflectLongexpected valuesTesting
testFromJsonRelated