Skip to content

Fix NoClassDefFoundError for DefaultJsonSerializer$LazyHolder in ProGuard/R8 release builds #530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −0
Draft

Fix NoClassDefFoundError for DefaultJsonSerializer$LazyHolder in ProGuard/R8 release builds #530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions proguard-rules.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,17 @@
# Keep Payload classes that get sent to Optimizely's backend
-keep class com.optimizely.ab.event.internal.payload.** { *; }

# Keep the DefaultJsonSerializer and its LazyHolder inner class.
# LogEvent.getBody() calls DefaultJsonSerializer.getInstance() which accesses
# LazyHolder.INSTANCE via the initialization-on-demand holder pattern.
# Without this rule, R8/ProGuard strips LazyHolder and causes:
# NoClassDefFoundError: com.optimizely.ab.event.internal.serializer.DefaultJsonSerializer$LazyHolder
-keep class com.optimizely.ab.event.internal.serializer.DefaultJsonSerializer { *; }
-keep class com.optimizely.ab.event.internal.serializer.DefaultJsonSerializer$LazyHolder { *; }
# GsonSerializer is the serializer selected at runtime on Android (Gson is bundled; Jackson is not).
# Keeping it ensures R8 does not strip the implementation that DefaultJsonSerializer.create() returns.
-keep class com.optimizely.ab.event.internal.serializer.GsonSerializer { *; }

# Keep these for logging purposes
-keep class com.optimizely.ab.bucketing.DecisionService { *; }
-keep class com.optimizely.ab.Optimizely { *; }
Expand Down