Skip to content

Cleanup pre-commit hooks and change to prek#676

Merged
timmens merged 4 commits intomainfrom
remove-mypy-precommit-hook
Mar 12, 2026
Merged

Cleanup pre-commit hooks and change to prek#676
timmens merged 4 commits intomainfrom
remove-mypy-precommit-hook

Conversation

@timmens
Copy link
Member

@timmens timmens commented Mar 12, 2026

No description provided.

timmens and others added 2 commits March 12, 2026 14:01
Enable the "D" (pydocstyle) rule set in ruff with Google convention.
Ignore missing-docstring rules (D100-D107) and a few content rules
(D205, D414, D415, D417) that are too noisy to enforce for now. Apply
auto-fixes for D301 (raw docstrings) and other minor formatting issues.

Also add ruff to the default pixi environment.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

timmens and others added 2 commits March 12, 2026 14:21
Update contributor guide and styleguide to recommend prek instead of
pre-commit. Fix the update-algo-selection-code hook to use
importlib + uv instead of pip, which is not available in prek
environments.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@timmens timmens changed the title Cleanup pre-commit hooks Cleanup pre-commit hooks and change to prek Mar 12, 2026
@codecov
Copy link

codecov bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/estimagic/estimate_ml.py 82.47% <ø> (ø)
src/estimagic/estimate_msm.py 89.68% <ø> (ø)
src/estimagic/estimation_table.py 84.33% <ø> (ø)
src/optimagic/benchmarking/benchmark_reports.py 98.38% <ø> (ø)
src/optimagic/differentiation/derivatives.py 96.18% <ø> (ø)
src/optimagic/logging/logger.py 93.89% <ø> (ø)
src/optimagic/logging/read_log.py 100.00% <ø> (ø)
src/optimagic/logging/sqlalchemy.py 95.56% <ø> (ø)
...agic/optimization/internal_optimization_problem.py 92.85% <ø> (ø)
src/optimagic/optimization/multistart.py 91.19% <ø> (ø)
... and 17 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timmens timmens merged commit eafa864 into main Mar 12, 2026
21 checks passed
@timmens timmens deleted the remove-mypy-precommit-hook branch March 12, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants