security/acme-client: always use configured cert name in cert description#5282
Open
pgerber wants to merge 1 commit intoopnsense:masterfrom
Open
security/acme-client: always use configured cert name in cert description#5282pgerber wants to merge 1 commit intoopnsense:masterfrom
pgerber wants to merge 1 commit intoopnsense:masterfrom
Conversation
…tion This a fix for the PHP warning below. I propose to simply never use the certificate name because: a) It's easier to understand if the description always has the same source. b) The use of a common name is no longer recommended and will disappear sooner or later anyway [1,2]. [1]: https://letsencrypt.org/docs/glossary/#def-CN [2]: https://letsencrypt.org/docs/profiles/#tlsserver Related PHP warning: [02-Mar-2026 15:02:54 Etc/UTC] PHP Warning: Undefined array key "commonname" in /usr/local/opnsense/mvc/app/library/OPNsense/AcmeClient/LeCertificate.php on line 206
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important notices
Before you submit a pull request, we ask you kindly to acknowledge the following:
If AI was used, please disclose:
n/a
Related issue
n/a
Describe the problem
A PHP warning is triggered.
Describe the proposed solution
See commit message.