sysutils/nut: Add support for any number of any UPS driver#5276
Open
yodaldevoid wants to merge 1 commit intoopnsense:masterfrom
Open
sysutils/nut: Add support for any number of any UPS driver#5276yodaldevoid wants to merge 1 commit intoopnsense:masterfrom
yodaldevoid wants to merge 1 commit intoopnsense:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important notices
Before you submit a pull request, we ask you kindly to acknowledge the following:
If AI was used, please disclose:
Related issue
Closes #5275 and #5273
Describe the problem
The plugin currently only realistically supports one UPS at a time. It also only supports only one of each driver. Finally it only supports the short list of manually supported drivers, despite the fact that most of them have the exact same options.
Describe the proposed solution
UPSs are now defined in an array field, similar to firewall rules. Each UPS has its own name, driver, port, and additional options. The driver is simply a text field to allow any driver to be entered.
Netclient has been given its own name field as the global UPS name field has been removed.
Validation has been added to ensure that each UPS defined is unique. Validation has also been added to ensure the NUT server is listening on a loopback address when local UPSs are defined. Finally, if NUT is set to netclient mode a warning has been added to alert the user that any local UPS definitions (a.k.a. anything other than netclient) will be disabled.