Introduce configurable interface for probe management#673
Open
fmount wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Open
Introduce configurable interface for probe management#673fmount wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
fmount wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
Conversation
stuggi
reviewed
Feb 23, 2026
This patch introduces the ProbeOverrides interface that enables service operators to properly configure and tune liveness, readiness and startup probes for their deployments. This implementation provides: - A ProbeConf struct for standardized probe configuration (path, delays, timeouts, periods and failure thresholds) - A ProvbeOverrides interface that allows service operators to extend their API specs and provide a common set of overrides - A CreateProbeSet function that can be called from the service operators as the main entrypoint to generate a set of probes that should be applied to a Pod. With this function operators can either provide a set of overrides or rely on the defaults defined in the service operator. - A ValidateProbes function to validate (mostly on Updates), at webhooks level, the values provided as user input The functions and the interface provided by this patch reduce the amount of duplicated code that should be implemented in the service operators. Jira: OSPRH-26731 Signed-off-by: Francesco Pantano <fpantano@redhat.com>
stuggi
reviewed
Feb 23, 2026
| } | ||
|
|
||
| // SetProbes - configures and returns liveness and readiness probes based on the provided settings | ||
| func SetProbes(port int, disableNonTLSListeners bool, config ProbeConfig) (*v1.Probe, *v1.Probe, error) { |
Contributor
There was a problem hiding this comment.
not used in the current operators, so good to do this change without deprecate them first
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch introduces the
ProbeOverridesinterface that enables service operators to properly configure and tuneliveness,readinessandstartupprobes for their deployments.This implementation provides:
ProbeConfstruct for standardized probe configuration (path,delays,timeouts,periodsandfailurethresholds)ProbeOverridesinterface that allows service operators to extend theirAPIspecs and provide a common set of overridesCreateProbeSetfunction that can be called from the service operators as the main entrypoint to generate a set of probes that should be applied to aPod. With this function operators can either provide a set of overrides or rely on the defaults defined in the service operator.ValidateProbesfunction to validate (mostly onUpdates), atwebhookslevel, the values provided as user input.The functions and the interface provided by this patch reduce the amount of duplicated code that should be implemented in the service operators.
Jira: https://issues.redhat.com/browse/OSPRH-26731