Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0bb4f39f1ee54ed08b69e463f6636194 ✔️ openstack-k8s-operators-content-provider SUCCESS in 27m 37s |
vakwetu
force-pushed
the
add_skmo_addition
branch
from
c89fd6f to
4b74f0f
Compare
Initial testing
We need to separate the common bits out and use some inheritance to avoid duplication, but this is proving problematic right now. Just duplicate stuff now to make sure we have all the other bits in place.
Add a _cifmw_va_common_loaded sentinel variable to va-common.yml and check for it in the auto-include logic in reproducer.yml, deploy-edpm-reuse.yaml, and playbooks/adoption/pre.yml. This prevents va-common.yml from being loaded twice when it is already included via cifmw_parent_scenario, which would otherwise clobber overrides set by parent scenario files. With this fix, va-multi-skmo.yml can safely inherit from both va-common.yml and va-multi.yml via cifmw_parent_scenario, replacing the previous ~400-line standalone copy with a minimal override file.
vakwetu
force-pushed
the
add_skmo_addition
branch
from
4b74f0f to
4184f2b
Compare
|
Build failed (check pipeline). Post https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/926d2a7534a24c488b20e8e93c851a78 ✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 34m 18s |
1 participant
We are trying to use the inheritance mechanism. This hasn't worked well in the past, but lets see.