Skip to content

[os_must_gather] Continue getting pod resources when metrics available#3694

Merged
danpawlik merged 1 commit intoopenstack-k8s-operators:mainfrom
danpawlik:add-info-must-gather
Feb 25, 2026
Merged

[os_must_gather] Continue getting pod resources when metrics available#3694
danpawlik merged 1 commit intoopenstack-k8s-operators:mainfrom
danpawlik:add-info-must-gather

Conversation

@danpawlik
Copy link
Contributor

@danpawlik danpawlik commented Feb 18, 2026

On some deployments especially on CRC, where we don't enable openshift-monitoring, the log files are empty.
In that case, those tasks can be just skipped.

@danpawlik danpawlik requested review from a team and elfiesmelfie February 18, 2026 13:19
elfiesmelfie
elfiesmelfie requested changes Feb 18, 2026
View reviewed changes
@danpawlik danpawlik force-pushed the add-info-must-gather branch from a0008c9 to 69c089a Compare February 19, 2026 07:27
@danpawlik danpawlik force-pushed the add-info-must-gather branch from 69c089a to 24ead21 Compare February 19, 2026 10:19
@danpawlik danpawlik force-pushed the add-info-must-gather branch from 24ead21 to 3b426f2 Compare February 19, 2026 10:21
elfiesmelfie added a commit to elfiesmelfie/telemetry-operator that referenced this pull request Feb 19, 2026
@elfiesmelfie
test cifmw#3694
b576746 
Depends-On: openstack-k8s-operators/ci-framework#3694
@elfiesmelfie elfiesmelfie mentioned this pull request Feb 19, 2026
Open
elfiesmelfie
elfiesmelfie reviewed Feb 19, 2026
View reviewed changes
Copy link
Contributor

@elfiesmelfie elfiesmelfie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm running this with one of the telemetry-operator jobs, which needs openshift-monitoring enabled.

openstack-k8s-operators/telemetry-operator#849

evallesp
evallesp reviewed Feb 24, 2026
View reviewed changes
@danpawlik
[os_must_gather] Continue getting pod resources when metrics available
dec1889 
On some deployments especially on CRC, where we don't enable
openshift-monitoring, the log files are empty.
In that case, those tasks can be just skipped.

Signed-off-by: Daniel Pawlik <dpawlik@redhat.com>
@danpawlik danpawlik force-pushed the add-info-must-gather branch from 3b426f2 to dec1889 Compare February 24, 2026 09:51
@evallesp
Copy link
Contributor

evallesp commented Feb 24, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 24, 2026
amartyasinha
amartyasinha approved these changes Feb 24, 2026
View reviewed changes
Copy link
Contributor

@amartyasinha amartyasinha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@danpawlik
Copy link
Contributor Author

danpawlik commented Feb 24, 2026

recheck

1 similar comment
@danpawlik
Copy link
Contributor Author

danpawlik commented Feb 24, 2026

recheck

@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Feb 24, 2026

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/bd50a49c3deb453f8ab0d7fc5ae78965

✔️ openstack-k8s-operators-content-provider SUCCESS in 28m 58s
❌ podified-multinode-edpm-deployment-crc RETRY_LIMIT in 11m 16s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 14m 59s
❌ cifmw-crc-podified-edpm-baremetal-minor-update RETRY_LIMIT in 14m 42s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 47s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 57s
✔️ cifmw-pod-pre-commit SUCCESS in 7m 57s
❌ cifmw-molecule-os_must_gather RETRY_LIMIT in 13m 46s

@danpawlik
Copy link
Contributor Author

danpawlik commented Feb 24, 2026

recheck

@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Feb 24, 2026

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/3c89923b78924821bbf83cb0b22402f3

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 36m 12s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 22m 15s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 14m 55s
❌ cifmw-crc-podified-edpm-baremetal-minor-update RETRY_LIMIT in 14m 26s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 39s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 01s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 11s
❌ cifmw-molecule-os_must_gather RETRY_LIMIT in 12m 56s

@danpawlik
Copy link
Contributor Author

danpawlik commented Feb 25, 2026

recheck

@amartyasinha
Copy link
Contributor

amartyasinha commented Feb 25, 2026

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 25, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amartyasinha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@danpawlik danpawlik merged commit 25424dc into openstack-k8s-operators:main Feb 25, 2026
7 of 9 checks passed
@danpawlik danpawlik deleted the add-info-must-gather branch February 25, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elfiesmelfie elfiesmelfie elfiesmelfie approved these changes

@evallesp evallesp evallesp approved these changes

@amartyasinha amartyasinha amartyasinha approved these changes

Assignees

@evallesp evallesp

@amartyasinha amartyasinha

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@danpawlik @evallesp @amartyasinha @elfiesmelfie