[sushy_emulator] Fix list handling for VM instances

[holser]

• Replace complex Jinja2 for-loop with idiomatic filter chain
  (dict2items | selectattr | map | list)
• Remove regex_replace in favor of join(', ') in template
• Keep variable as list for loop/index access in tasks
• Template formats output as comma-separated: uuid1, uuid2, uuid3

Co-authored-by: Cursor cursoragent@cursor.com
Signed-off-by: Sergii Golovatiuk sgolovat@redhat.com

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign evallesp for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/06565e38a53248ac9155519606efd3f4

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 54m 41s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 22m 58s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 39m 45s
❌ cifmw-crc-podified-edpm-baremetal-minor-update FAILURE in 37m 03s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 24s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 7m 57s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 06s
❌ cifmw-molecule-reproducer FAILURE in 12m 12s
❌ cifmw-molecule-sushy_emulator FAILURE in 18m 55s

[hjensas]

We need the regex to convert this to a comma separated string, instead of a \n line-break reparated string. Because it is the input for sushy emulator config file:

ci-framework/roles/sushy_emulator/templates/config_conf.j2

Line 38 in 4944fff

SUSHY_EMULATOR_ALLOWED_INSTANCES = {{ _cifmw_sushy_emulator_instances }}

_matching_vms is of tpy string, not of type list.

hmm, so rethinking - the string would not be newline separated, it would be a ["uuid-0", "uuid-1", "uuid-2"] ?

so what we actually need is something like:

_cifmw_sushy_emulator_instances: "{{ _matching_vms | from_yaml }} or from_json ?

[holser]

I don't think so as

We have libvirt-uuids.yml with the following content

libvirt_uuid:
    cifmw-ocp-master-0: 17a164e9-46af-504d-b750-4d768f4b1b71
    cifmw-ocp-master-1: a91fb6bc-1bf2-532a-b3ef-4bdecda8a0dd
    cifmw-ocp-master-2: 8e6c659c-27df-5ead-bdf2-59b8dde77263
    cifmw-ocp-worker-0: f2db0152-6cdc-5cef-9294-f1248364389a

When we slurp data we get the following structure

        "cifmw_libvirt_manager_uuids": {
            "cifmw-ocp-master-0": "17a164e9-46af-504d-b750-4d768f4b1b71",
            "cifmw-ocp-master-1": "a91fb6bc-1bf2-532a-b3ef-4bdecda8a0dd",
            "cifmw-ocp-master-2": "8e6c659c-27df-5ead-bdf2-59b8dde77263",
            "cifmw-ocp-worker-0": "f2db0152-6cdc-5cef-9294-f1248364389a"
        }

In Generate list of filtered VMs task we set matching_vms as empty list by

matching_vms = []

then in for loop we add UUIDs to list of matching vms as

set _ = matching_vms.append(uuid)

so we get the following list

"_cifmw_sushy_emulator_instances": [
            "17a164e9-46af-504d-b750-4d768f4b1b71",
            "a91fb6bc-1bf2-532a-b3ef-4bdecda8a0dd",
            "8e6c659c-27df-5ead-bdf2-59b8dde77263",
            "f2db0152-6cdc-5cef-9294-f1248364389a"
        ]

after my change. We don't need to convert it to comma separated string as whole code is around list for _cifmw_sushy_emulator_instances variable. In roles/reproducer/tasks/generate_bm_info.yml we have the following code

{% if item.value in _cifmw_sushy_emulator_instances | default([]) %}

or roles/sushy_emulator/tasks/create_container.yml has

req = urllib.request.Request('http://localhost:8000/redfish/v1/Systems/{{ _cifmw_sushy_emulator_instances[0] }}');

[holser]

if we need CSV in template we should add it to template and operate lists in ansible code

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/8836ee39b1574d0d98c28b131b7794d5

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 19m 26s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 19m 08s
✔️ cifmw-crc-podified-edpm-baremetal SUCCESS in 1h 29m 01s
❌ cifmw-crc-podified-edpm-baremetal-minor-update FAILURE in 2h 07m 13s
✔️ cifmw-pod-zuul-files SUCCESS in 5m 00s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 27m 37s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 26s
✔️ cifmw-molecule-reproducer SUCCESS in 16m 08s
✔️ cifmw-molecule-sushy_emulator SUCCESS in 19m 01s

[softwarefactory-project-zuul]

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/0ce7a2e60fa3444c9989ebe7fd09b9b1

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 37m 13s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 24m 14s
❌ cifmw-crc-podified-edpm-baremetal RETRY_LIMIT in 15m 01s
❌ cifmw-crc-podified-edpm-baremetal-minor-update RETRY_LIMIT in 14m 31s
✔️ cifmw-pod-zuul-files SUCCESS in 4m 33s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 8m 39s
✔️ cifmw-pod-pre-commit SUCCESS in 8m 13s
❌ cifmw-molecule-reproducer FAILURE in 12m 06s
❌ cifmw-molecule-sushy_emulator TIMED_OUT in 32m 41s