Skip to content

[サイト内検索] 検索対象が固定記事の場合、検索結果にフレームのアンカーを追加する／検索結果0件のときにメッセージを表示する #2387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
akagane99 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[サイト内検索] 検索対象が固定記事の場合、検索結果にフレームのアンカーを追加する／検索結果0件のときにメッセージを表示する #2387

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3608418
add: サイト内検索, 検索結果の固定記事にフレームのアンカーを追加
akagane99 Mar 18, 2026
7d08128
add: サイト内検索, 検索結果0件のときにメッセージを表示する
akagane99 Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions resources/views/plugins/user/searchs/default/searchs_result.blade.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
@if($searchs_results)
<div class="mt-3">
<dl>
@foreach($searchs_results as $searchs_result)
@forelse($searchs_results as $searchs_result)
<dt>
{{-- 登録日 --}}
@if($searchs_frame->view_posted_at)
Expand All @@ -36,7 +36,7 @@
@if($link_pattern[$searchs_result->plugin_name] == 'show_page_frame_post')
<a href="{{url('/')}}{{$link_base[$searchs_result->plugin_name]}}/{{$searchs_result->page_id}}/{{$searchs_result->frame_id}}/{{$searchs_result->post_id}}#frame-{{$searchs_result->frame_id}}">
@elseif($link_pattern[$searchs_result->plugin_name] == 'show_page')
<a href="{{url('/')}}{{$searchs_result->permanent_link}}">
<a href="{{url('/')}}{{$searchs_result->permanent_link}}#frame-{{$searchs_result->frame_id}}">
@else
{{-- 上記以外は想定していない為、取り敢えず permanent_link をリンク先とする --}}
<a href="{{url('/')}}{{$searchs_result->permanent_link}}">
Expand All @@ -57,7 +57,10 @@
<dd class="text-secondary search-result-body border-bottom">
{!! mb_strimwidth(strip_tags($searchs_result->body), 0, 160, '…') !!}
</dd>
@endforeach
@empty
{{-- 検索結果0件 --}}
<dd>{{ __('messages.search_results_empty') }}</dd>
Copy link
Contributor

@masaton0216 masaton0216 Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<dt> を伴わない <dd> はHTML仕様上、不正だったかと思うので、下記のようなコードはいかがでしょうか？（又は、 @forelse を使わず、 @foreach のままにして </dl> の後にifの条件分岐を置く）

  @forelse($searchs_results as $searchs_result)                                                                                                                  
      <dt>...</dt>
      <dd>...</dd>
      <dd>...</dd>                                                                                                                                               
  @empty
  @endforelse                                                                                                                                                    
  </dl>           

  @if($searchs_results->isEmpty())                                                                                                                               
      <p>{{ __('messages.search_results_empty') }}</p>
  @endif

@endforelse
</dl>
@php
$appends['search_keyword'] = old('search_keyword');
Expand Down
Loading