MG-203: Updating OAP team in OWNERS for must-gather#2203
MG-203: Updating OAP team in OWNERS for must-gather#2203shivprakashmuley wants to merge 1 commit intoopenshift:mainfrom
Conversation
|
@shivprakashmuley: This pull request references MG-203 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 WalkthroughUpdated OWNERS_ALIASES to remove a member from storage-approvers and introduced two new alias sections (mustgather-reviewers and mustgather-approvers) with five members each. Created a new OWNERS file for the mustgather CLI admin module that references these aliases. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shivprakashmuley The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@shivprakashmuley: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/verify-owners |
|
The OWNERS file contains untrusted users, which makes it INVALID. The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the openshift org. You can then trigger verification by writing
|
|
I'm not sure that there is any agreement (at least I am not told) about handing off the In any case, my comment in openshift/must-gather#522 (comment) is also relevant here. /close |
|
@ardaguclu: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
This PR adds OAP team members as approvers and reviewers for must-gather.