Skip to content

MG-203: Updating OAP team in OWNERS for must-gather#2203

Closed
shivprakashmuley wants to merge 1 commit intoopenshift:mainfrom
shivprakashmuley:update-mg-owners
Closed

MG-203: Updating OAP team in OWNERS for must-gather#2203
shivprakashmuley wants to merge 1 commit intoopenshift:mainfrom
shivprakashmuley:update-mg-owners

Conversation

@shivprakashmuley
Copy link

This PR adds OAP team members as approvers and reviewers for must-gather.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 18, 2026
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 18, 2026

@shivprakashmuley: This pull request references MG-203 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

This PR adds OAP team members as approvers and reviewers for must-gather.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Feb 18, 2026

No actionable comments were generated in the recent review. 🎉


Walkthrough

Updated OWNERS_ALIASES to remove a member from storage-approvers and introduced two new alias sections (mustgather-reviewers and mustgather-approvers) with five members each. Created a new OWNERS file for the mustgather CLI admin module that references these aliases.

Changes

Cohort / File(s) Summary
Ownership configuration
OWNERS_ALIASES
Removed dfajmon from storage-approvers. Added mustgather-reviewers and mustgather-approvers alias sections, each with 5 members: Prashanth684, TrilokGeer, swghosh, shivprakashmuley, pravekum.
New OWNERS file
pkg/cli/admin/mustgather/OWNERS
New file created with reviewers and approvers sections referencing the mustgather-reviewers and mustgather-approvers aliases defined in OWNERS_ALIASES.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 18, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shivprakashmuley
Once this PR has been reviewed and has the lgtm label, please assign ingvagabund for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Feb 18, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 18, 2026

@shivprakashmuley: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-serial-2of2 7d7b507 link true /test e2e-aws-ovn-serial-2of2
ci/prow/e2e-aws-oc-ote 7d7b507 link false /test e2e-aws-oc-ote
ci/prow/e2e-agnostic-ovn-cmd 7d7b507 link true /test e2e-agnostic-ovn-cmd
ci/prow/e2e-aws-ovn-serial-1of2 7d7b507 link true /test e2e-aws-ovn-serial-1of2
ci/prow/e2e-aws-ovn-upgrade 7d7b507 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn 7d7b507 link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@swghosh
Copy link
Member

swghosh commented Feb 25, 2026

/verify-owners

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 25, 2026

The OWNERS file contains untrusted users, which makes it INVALID. The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the openshift org. You can then trigger verification by writing /verify-owners in a comment.

  • pravekum
    • User is not a member of the org. User is not a collaborator. Satisfy at least one of these conditions to make the user trusted.

@ardaguclu
Copy link
Member

I'm not sure that there is any agreement (at least I am not told) about handing off the oc adm must-gather command from Workloads team. oc adm must-gather command basically runs a privileged pod on given node. This is conceptually separate process from must-gather image or must-gather-operator.

In any case, my comment in openshift/must-gather#522 (comment) is also relevant here.

cc: @ingvagabund @atiratree

/close

@openshift-ci openshift-ci bot closed this Feb 26, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 26, 2026

@ardaguclu: Closed this PR.

Details

In response to this:

I'm not sure that there is any agreement (at least I am not told) about handing off the oc adm must-gather command from Workloads team. oc adm must-gather command basically runs a privileged pod on given node. This is conceptually separate process from must-gather image or must-gather-operator.

In any case, my comment in openshift/must-gather#522 (comment) is also relevant here.

cc: @ingvagabund @atiratree

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants