Skip to content

OCPBUGS-77750: Auto-detect GNSS serial port by NIC#559

Open
vitus133 wants to merge 1 commit intoopenshift:release-4.21from
vitus133:nmea-port-4.21
Open

OCPBUGS-77750: Auto-detect GNSS serial port by NIC#559
vitus133 wants to merge 1 commit intoopenshift:release-4.21from
vitus133:nmea-port-4.21

Conversation

@vitus133
Copy link
Contributor

@vitus133 vitus133 commented Mar 5, 2026

Address the problem of randomly changing GNSS device names after host reboot. Use ts2phc configuration to determine the operation mode and the clock chain leading NIC. In the T-GM case, find the GNSS device by browsing the leading NIC SysFS structure. Add the discovered serial port address to ts2phc.conf.
The mechanism only works if ts2phc.nmea_serialport setting is omitted from the PTP profile. If the setting is present, it acts as before the change, leaving "Automatic" Vs. "Manual" setting decision to user.

Assisted by Cursor AI

Address the problem of randomly changing GNSS device names after host
reboot. Use ts2phc configuration to determine the operation mode and
the clock chain leading NIC. In the T-GM case, find the GNSS device
by browsing the leading NIC SysFS structure. Add the discovered serial
port address to ts2phc.conf.
The mechanism only works if `ts2phc.nmea_serialport` setting is omitted
from the PTP profile. If the setting is present, it acts as before the
change, leaving "Automatic" Vs. "Manual" setting decision to user.

Assisted by Cursor AI

Signed-off-by: Vitaly Grinberg <vgrinber@redhat.com>
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 5, 2026
@openshift-ci-robot
Copy link
Contributor

@vitus133: This pull request references Jira Issue OCPBUGS-77750, which is invalid:

  • expected the bug to target either version "4.21." or "openshift-4.21.", but it targets "4.20.z" instead
  • expected dependent Jira Issue OCPBUGS-77751 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead
  • expected dependent Jira Issue OCPBUGS-77751 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Address the problem of randomly changing GNSS device names after host reboot. Use ts2phc configuration to determine the operation mode and the clock chain leading NIC. In the T-GM case, find the GNSS device by browsing the leading NIC SysFS structure. Add the discovered serial port address to ts2phc.conf.
The mechanism only works if ts2phc.nmea_serialport setting is omitted from the PTP profile. If the setting is present, it acts as before the change, leaving "Automatic" Vs. "Manual" setting decision to user.

Assisted by Cursor AI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from josephdrichard and jzding March 5, 2026 12:14
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vitus133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2026
@vitus133
Copy link
Contributor Author

vitus133 commented Mar 5, 2026

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@vitus133: This pull request references Jira Issue OCPBUGS-77750, which is invalid:

  • expected dependent Jira Issue OCPBUGS-77751 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead
  • expected dependent Jira Issue OCPBUGS-77751 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 5, 2026

@vitus133: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants