OCPBUGS-78291: Allow azure-disk sidecars to read VolumeAttributeClasses

[jsafrane]

The driver supports volume modification and thus the sidecars need to be able to read VACs.

@openshift/storage

[coderabbitai]

📝 Walkthrough

Walkthrough

An import in the Azure Disk driver was aliased to deploymentversioncontroller and references updated. Two RBAC asset files were added to controller sidecars via WithAdditionalAssets: base/rbac/volumeattributesclass_reader_provisioner_binding.yaml and base/rbac/volumeattributesclass_reader_resizer_binding.yaml. E2E test manifests were updated to load test/e2e/azure-disk/storageclass-premium-v2.yaml and a new test/e2e/azure-disk/volumeattributesclass.yaml declaring a VolumeAttributesClass premium-iops with driverName: disk.csi.azure.com and DiskMBpsReadWrite: "750".

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main objective: granting azure-disk sidecars permission to read VolumeAttributeClasses, which is reflected in the code changes (RBAC bindings) and test additions.
Description check	✅ Passed	The description is directly related to the changeset, explaining that the driver supports volume modification and thus sidecars need to read VolumeAttributeClasses, which matches the implementation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

📝 Coding Plan

• Generate coding plan for human review comments

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can suggest fixes for GitHub Check annotations.

Configure the reviews.tools.github-checks setting to adjust the time to wait for GitHub Checks to complete.

[jsafrane]

/jira refresh

[jsafrane]

/test images

[jsafrane]

/test

[jsafrane]

/test all

[jsafrane]

/jira refresh

[openshift-ci-robot]

@jsafrane: This pull request references Jira Issue OCPBUGS-78291, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jsafrane]

/testwith openshift/csi-operator/master/e2e-azure-csi openshift/cluster-storage-operator#683

[openshift-ci]

@jsafrane, testwith: could not generate prow job. ERROR:

could not determine ci op config from metadata: got unexpected http 404 status code from configresolver: failed to get config: could not find any config for branch master on repo openshift/csi-operator

[jsafrane]

/testwith openshift/csi-operator/main/e2e-azure-csi openshift/cluster-storage-operator#683

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@test/e2e/azure-disk/storageclass-premium-v2.yaml`:
- Line 7: Replace the incorrect parameter key "skuname" with the correctly cased
"skuName" in the StorageClass parameters so the Azure Disk CSI driver
(disk.csi.azure.com) recognizes the SKU value (e.g., change skuname:
PremiumV2_LRS to skuName: PremiumV2_LRS); locate the parameter entry labeled
"skuname" in storageclass-premium-v2.yaml and update its key only, preserving
the value and surrounding YAML structure.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 514f648d-b401-4c74-98aa-0055761be30c

📥 Commits

Reviewing files that changed from the base of the PR and between 555280d and 6b68fad.

📒 Files selected for processing (3)

• test/e2e/azure-disk/manifest.yaml
• test/e2e/azure-disk/storageclass-premium-v2.yaml
• test/e2e/azure-disk/volumeattributesclass.yaml

🚧 Files skipped from review as they are similar to previous changes (2)

• test/e2e/azure-disk/manifest.yaml
• test/e2e/azure-disk/volumeattributesclass.yaml

[jsafrane]

/testwith openshift/csi-operator/main/e2e-azure-csi openshift/cluster-storage-operator#683

[jsafrane]

/testwith openshift/csi-operator/main/e2e-azure-csi openshift/cluster-storage-operator#683

[jsafrane]

/testwith openshift/csi-operator/main/e2e-azure-csi openshift/cluster-storage-operator#683
?!

[openshift-ci]

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure	d20065f	link	true	/test e2e-azure
ci/prow/hypershift-aws-e2e-external	d20065f	link	true	/test hypershift-aws-e2e-external
ci/prow/e2e-azure-file-csi	d20065f	link	true	/test e2e-azure-file-csi
ci/prow/e2e-azure-csi	d20065f	link	true	/test e2e-azure-csi
ci/prow/e2e-azurestack-csi	d20065f	link	false	/test e2e-azurestack-csi
ci/prow/e2e-azure-ovn-upgrade	d20065f	link	true	/test e2e-azure-ovn-upgrade
ci/prow/e2e-azure-file-nfs-csi	d20065f	link	true	/test e2e-azure-file-nfs-csi
ci/prow/e2e-azure-csi-extended	d20065f	link	false	/test e2e-azure-csi-extended

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jsafrane]

/testwith openshift/csi-operator/main/e2e-azure-csi openshift/cluster-storage-operator#683