refactor: simplify redundant error checking conditions

[vprashar2929]

This commit simplifies the error checking conditions in the

• lib/resourcebuilder/apps.go
• pkg/cvo/upgradeable.go

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

---

Walkthrough

Two separate conditional logic simplifications in cluster upgrade and configuration handling code. The first unifies internal load balancer URL substitution under a single nil-error condition. The second replaces redundant else-if guards with simpler else statements in error handling checks.

Changes

Cohort / File(s)	Summary
Internal Load Balancer URL Substitution lib/resourcebuilder/apps.go	Changed conditional gating for CVO deployment internal load balancer URL substitution to check err == nil directly, consolidating the logic path for URL parsing and host/port extraction.
Error Handling Conditional Simplification pkg/cvo/upgradeable.go	Replaced two redundant else if err != nil conditionals with plain else statements in clusterAdminAcksCompletedUpgradeable checks, functionally equivalent given surrounding guards.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vprashar2929
Once this PR has been reviewed and has the lgtm label, please assign wking for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@vprashar2929: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[DavidHurta]

/cc