SPLAT-2320: vsphere vm-host zonal ga#2731
SPLAT-2320: vsphere vm-host zonal ga#2731jcpowermac wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
openshift-ci-robot
added
the
jira/valid-reference
|
@jcpowermac: This pull request references SPLAT-2320 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hello @jcpowermac! Some important instructions when contributing to openshift/api: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Cache: Disabled due to data retention organization setting Knowledge base: Disabled due to data retention organization setting ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (10)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe VSphereHostVMGroupZonal feature gate declaration was expanded to include inDefault() and inOKD() in addition to inTechPreviewNoUpgrade() and inDevPreviewNoUpgrade(). Feature-gate manifests for Hypershift and SelfManagedHA variants (Default and OKD) were updated to move VSphereHostVMGroupZonal from disabled to enabled. Multiple CRD OpenAPI schemas (infrastructures and controllerconfigs for Default and OKD) were updated to add two x-kubernetes-validations enforcing cross-field rules between zoneAffinity.type and regionAffinity.type. Features.md had the VSphereHostVMGroupZonal row relocated within a table without content changes. 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.5.0)Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented Comment |
openshift-ci
bot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
This promotion will be validated/approved by @sgaoshang since enabling this topology has been problematic using nested vSphere and we are not able to test this in our typical vSphere CI environments do to region/zone tagging requirements. /assign @sgaoshang |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
features/features.go (1)
183-189: Missing space after comma inenable()call.Line 188 has inconsistent formatting compared to other feature gates in this file. There's a missing space after
inOKD(),beforeinTechPreviewNoUpgrade().🔧 Suggested fix for formatting consistency
FeatureGateVSphereHostVMGroupZonal = newFeatureGate("VSphereHostVMGroupZonal"). reportProblemsToJiraComponent("splat"). contactPerson("jcpowermac"). productScope(ocpSpecific). enhancementPR("https://github.com/openshift/enhancements/pull/1677"). - enable(inDefault(), inOKD(),inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade()). + enable(inDefault(), inOKD(), inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade()). mustRegister()🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@features/features.go` around lines 183 - 189, The enable() call on FeatureGateVSphereHostVMGroupZonal has inconsistent spacing (missing space after the comma between inOKD() and inTechPreviewNoUpgrade()); update the enable(...) invocation in the FeatureGateVSphereHostVMGroupZonal declaration to match file formatting by adding a space after the comma so it reads inDefault(), inOKD(), inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade(), ensuring the rest of the fluent chain (reportProblemsToJiraComponent, contactPerson, productScope, enhancementPR, mustRegister) remains unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@features/features.go`:
- Around line 183-189: The enable() call on FeatureGateVSphereHostVMGroupZonal
has inconsistent spacing (missing space after the comma between inOKD() and
inTechPreviewNoUpgrade()); update the enable(...) invocation in the
FeatureGateVSphereHostVMGroupZonal declaration to match file formatting by
adding a space after the comma so it reads inDefault(), inOKD(),
inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade(), ensuring the rest of the
fluent chain (reportProblemsToJiraComponent, contactPerson, productScope,
enhancementPR, mustRegister) remains unchanged.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (6)
features.mdfeatures/features.gopayload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yamlpayload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yamlpayload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yamlpayload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
jcpowermac
force-pushed
the
vm-host-zonal-ga
branch
from
f10ee89 to
1b93745
Compare
openshift-ci
bot
added
size/S
There was a problem hiding this comment.
🧹 Nitpick comments (1)
features/features.go (1)
181-187: Minor formatting inconsistency: missing space after comma.Line 186 is missing a space between
inOKD(),andinTechPreviewNoUpgrade(), which is inconsistent with the formatting used elsewhere in this file (e.g., lines 82, 91, 107, 194).✏️ Suggested fix
FeatureGateVSphereHostVMGroupZonal = newFeatureGate("VSphereHostVMGroupZonal"). reportProblemsToJiraComponent("splat"). contactPerson("jcpowermac"). productScope(ocpSpecific). enhancementPR("https://github.com/openshift/enhancements/pull/1677"). - enable(inDefault(), inOKD(),inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade()). + enable(inDefault(), inOKD(), inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade()). mustRegister()🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@features/features.go` around lines 181 - 187, The enable(...) call for FeatureGateVSphereHostVMGroupZonal has a missing space after the comma between inOKD() and inTechPreviewNoUpgrade(); update the enable invocation on FeatureGateVSphereHostVMGroupZonal so it reads enable(inDefault(), inOKD(), inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade()) — i.e., insert a single space after the comma to match the file's existing formatting for other feature gates.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@features/features.go`:
- Around line 181-187: The enable(...) call for
FeatureGateVSphereHostVMGroupZonal has a missing space after the comma between
inOKD() and inTechPreviewNoUpgrade(); update the enable invocation on
FeatureGateVSphereHostVMGroupZonal so it reads enable(inDefault(), inOKD(),
inTechPreviewNoUpgrade(), inDevPreviewNoUpgrade()) — i.e., insert a single space
after the comma to match the file's existing formatting for other feature gates.
ℹ️ Review info
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge base: Disabled due to data retention organization setting
📒 Files selected for processing (6)
features.mdfeatures/features.gopayload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yamlpayload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yamlpayload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yamlpayload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
- payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
jcpowermac
force-pushed
the
vm-host-zonal-ga
branch
from
1b93745 to
a8b0a3d
Compare
This commit is to add the vSphere vm-host zonal feature to default (GA).
jcpowermac
force-pushed
the
vm-host-zonal-ga
branch
from
a8b0a3d to
3757b1d
Compare
openshift-ci
bot
added
size/L
|
@jcpowermac: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
This commit is to add the vSphere vm-host zonal feature to default (GA).