Use set -euxo pipefail in 03, 05, and 06 scripts#1888
Open
elfosardo wants to merge 1 commit intoopenshift-metal3:masterfrom
Open
Use set -euxo pipefail in 03, 05, and 06 scripts#1888elfosardo wants to merge 1 commit intoopenshift-metal3:masterfrom
elfosardo wants to merge 1 commit intoopenshift-metal3:masterfrom
Conversation
Replace separate set -x / set -e with set -euxo pipefail in 03_build_installer.sh, 05_create_install_config.sh, and 06_create_cluster.sh for consistency with the other main scripts. Guard optional environment variables with :- defaults in 06_create_cluster.sh, utils.sh, and ocp_install_env.sh to avoid nounset errors for variables not set by common.sh.
elfosardo
force-pushed
the
euxo-pipefail-them-all
branch
from
7b2a531 to
5a64d89
Compare
Member
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dtantsur The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace separate set -x / set -e with set -euxo pipefail in 03_build_installer.sh, 05_create_install_config.sh, and 06_create_cluster.sh for consistency with the other main scripts.
Guard environment variables not set by common.sh with :- defaults in 06_create_cluster.sh to avoid nounset errors.