Conversation
|
@codex review |
There was a problem hiding this comment.
Pull request overview
This PR aims to make the protobuf module publishable as a standalone Maven artifact (jar), and updates the build configuration to reflect the intended artifact naming.
Changes:
- Rename the
protobufGradle project (viasettings.gradle) toorlib-protobuf. - Add Maven publishing + signing configuration to
protobuf/build.gradle, including a sources jar. - Update ORLib to depend on the renamed protobuf project.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
settings.gradle |
Renames the :protobuf project to orlib-protobuf. |
protobuf/build.gradle |
Adds maven-publish + signing and configures publication metadata, repo selection, and sources jar. |
ORLib/build.gradle |
Updates the inter-module dependency to reference the protobuf module under the new name. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
Let me know @ebariaux if the comments make sense. |
|
I tested building both the OR Android app and a custom app with this configuration and it worked fine. |
No description provided.