Skip to content

Publish protobuf jar#47

Merged
MartinaeyNL merged 1 commit intomainfrom
enhancement/publish-protobuf
Apr 9, 2026
Merged

Publish protobuf jar#47
MartinaeyNL merged 1 commit intomainfrom
enhancement/publish-protobuf

Conversation

@ebariaux
Copy link
Copy Markdown
Contributor

@ebariaux ebariaux commented Apr 8, 2026

No description provided.

@ebariaux ebariaux requested a review from a team April 8, 2026 15:09
@ebariaux ebariaux added the Enhancement New feature or request label Apr 8, 2026
@ebariaux ebariaux linked an issue Apr 8, 2026 that may be closed by this pull request
@wborn wborn requested a review from Copilot April 8, 2026 15:18
@wborn
Copy link
Copy Markdown
Member

wborn commented Apr 8, 2026

@codex review

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR aims to make the protobuf module publishable as a standalone Maven artifact (jar), and updates the build configuration to reflect the intended artifact naming.

Changes:

  • Rename the protobuf Gradle project (via settings.gradle) to orlib-protobuf.
  • Add Maven publishing + signing configuration to protobuf/build.gradle, including a sources jar.
  • Update ORLib to depend on the renamed protobuf project.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
settings.gradle Renames the :protobuf project to orlib-protobuf.
protobuf/build.gradle Adds maven-publish + signing and configures publication metadata, repo selection, and sources jar.
ORLib/build.gradle Updates the inter-module dependency to reference the protobuf module under the new name.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@MartinaeyNL
Copy link
Copy Markdown
Contributor

Let me know @ebariaux if the comments make sense.
I'm happy to merge this, as I would love to try this new artifact 👍

@ebariaux
Copy link
Copy Markdown
Contributor Author

ebariaux commented Apr 9, 2026

I tested building both the OR Android app and a custom app with this configuration and it worked fine.
@MartinaeyNL For me it's OK to merge (and create a new release)

Copy link
Copy Markdown
Contributor

@MartinaeyNL MartinaeyNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinaeyNL MartinaeyNL merged commit 766fd8f into main Apr 9, 2026
5 checks passed
@MartinaeyNL MartinaeyNL deleted the enhancement/publish-protobuf branch April 9, 2026 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

protobuf jar must be published as part of the build/release process

4 participants