Skip to content

add tacco#12

Merged
rcannood merged 2 commits into
mainfrom
add-tacco
May 14, 2026
Merged

add tacco#12
rcannood merged 2 commits into
mainfrom
add-tacco

Conversation

@dariarom94
Copy link
Copy Markdown
Contributor

Describe your changes

Checklist before requesting a review

  • I have performed a self-review of my code

  • Check the correct box. Does this PR contain:

    • Breaking changes
    • [X ] New functionality
    • Major changes
    • Minor changes
    • Bug fixes
  • Proposed changes are described in the CHANGELOG.md

  • CI Tests succeed and look good!

Added code for the tacco implementation and modified config to plug it in after the segmentation

@dariarom94 dariarom94 requested a review from rcannood May 12, 2026 07:50
Copy link
Copy Markdown
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great pr, mostly LGTM

Comment thread src/workflows/run_benchmark/config.vsh.yaml Outdated
Copy link
Copy Markdown
Member

@rcannood rcannood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@rcannood rcannood merged commit 4c8ae6a into main May 14, 2026
2 checks passed
@rcannood rcannood deleted the add-tacco branch May 14, 2026 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants