Skip to content

Add more checks to tests #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rcannood merged 1 commit into from
Apr 29, 2026
Merged

Add more checks to tests #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions ...ages/python/openproblems/src/openproblems/project/component_tests/run_and_check_output.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ def check_input_files(arguments: list) -> None:
print(">> Checking that all required input files exist", flush=True)
for arg in arguments:
if arg["type"] == "file" and arg["direction"] == "input" and arg["required"]:
assert not arg["must_exist"] or path.exists(
arg["value"]
), f"Input file '{arg['value']}' does not exist"
expected_path = arg.get("value")
assert expected_path is not None, f"Input argument '{arg['name']}' is missing a value"
assert not arg["must_exist"] or path.exists(expected_path), f"Input file '{expected_path}' does not exist"


def check_output_files(arguments: list) -> None:
Expand All @@ -33,9 +33,9 @@ def check_output_files(arguments: list) -> None:
print(">> Checking that all required output files were created", flush=True)
for arg in arguments:
if arg["type"] == "file" and arg["direction"] == "output" and arg["required"]:
assert not arg["must_exist"] or path.exists(
arg["value"]
), f"Output file '{arg['value']}' does not exist"
expected_path = arg.get("value")
assert expected_path is not None, f"Output argument '{arg['name']}' is missing a value"
assert not arg["must_exist"] or path.exists(expected_path), f"Output file '{expected_path}' does not exist"

print(">> Validating the contents and format of output files", flush=True)
for arg in arguments:
Expand Down Expand Up @@ -216,15 +216,15 @@ def get_argument_sets(config: dict, resources_dir: str) -> dict:
new_arg = arg.copy()
arg_info = new_arg.get("info") or {}
default_or_example = None
if arg_info.get("default"):
if arg_info.get("default") is not None:
default_or_example = arg_info["default"]
elif arg_info.get("example"):
elif arg_info.get("example") is not None:
default_or_example = arg_info["example"]
if isinstance(default_or_example, list):
default_or_example = default_or_example[0]

# use example to find test resource file
if default_or_example and arg["type"] == "file":
if default_or_example is not None and arg["type"] == "file":
if arg["direction"] == "input":
value = f"{resources_dir}/{default_or_example}"
else:
Expand Down