[FIX] missing f-string in dataset features error message#294
[FIX] missing f-string in dataset features error message#294PGijsbers merged 1 commit intoopenml:mainfrom
Conversation
WalkthroughIn the 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@PGijsbers While reading through the codebase, I spotted a small bug the error message in |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #294 +/- ##
=======================================
Coverage 54.20% 54.20%
=======================================
Files 38 38
Lines 1581 1581
Branches 137 137
=======================================
Hits 857 857
Misses 722 722
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thanks! I am restructuring the tests and guidelines. I'd still be happy to have more contributions but it might be useful to coordinate a bit. Are you on the OpenML Slack? I see a user there with the same handle. |
Description
The error message in
get_dataset_featureswas missing an f prefix on the string containing {dataset_id}. This caused users to see the literal text {dataset_id} instead of the actual dataset ID when a dataset had no features. Added the f prefix to correctly interpolate the variable.